Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ytdl_hook.lua #15453

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Trudeau566
Copy link

Add hevc

@CounterPillow
Copy link
Contributor

Did you actually test this for any particular case, and which site is this needed on? When I run it on a Nebula link, which does use HEVC, I get results like "vcodec": "hvc1.2.4.L150.90", which your source pattern wouldn't cover. Beyond that, it also doesn't seem needed, since mpv picks HEVC for that URL.

Also, your commit message doesn't follow the contribution guidelines.

@Trudeau566
Copy link
Author

您实际上是否针对任何特定情况对此进行了测试?哪个网站需要此功能?当我在使用 HEVC 的 Nebula 链接上运行它时,我得到如下结果 "vcodec": "hvc1.2.4.L150.90",您的源模式不会涵盖。除此之外,它似乎也不需要,因为 mpv 选择 HEVC 作为该 URL。

此外,您的提交消息不遵循贡献指南。

测试视频 https://www.bilibili.com/video/av113503117511187

PixPin_2024-12-08_14-31-10

PixPin_2024-12-08_14-33-13

Copy link

github-actions bot commented Dec 8, 2024

Download the artifacts for this pull request:

Windows
macOS

@kasper93
Copy link
Contributor

kasper93 commented Dec 8, 2024

@Trudeau566: Thank you. Could you also add a hvc1 for @CounterPillow case? And fix commit message according to docs https://github.com/mpv-player/mpv/blob/master/DOCS/contribute.md#write-good-commit-messages

There are possible more missing mappings here too, but not sure how relevant it would be to fix. Like I think ytdl would set vcodec to dvh1 or dvhe for dolby vision content and few more cases like that.

@kasper93 kasper93 added priority:stalled priority:needs-author-feedback The original author of the issue/PR needs to come back and respond to something and removed priority:stalled labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:needs-author-feedback The original author of the issue/PR needs to come back and respond to something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants