select.lua: select files with watch later files with g-w #15441

guidocella · 2024-12-05T12:51:24Z

Implement selection of files with watch later config files. Requires --write-filename-in-watch-later-config.

Suggested by llyyr. He also suggested showing this when mpv opens, but it completely covers the logo and the text, and stays open after dropping a file. Alternatively "Drop files or URLs to play here." could also suggest pressing g-h.

kasper93 · 2024-12-05T15:43:08Z

player/lua/select.lua

+    local watch_later_dir = mp.get_property("watch-later-dir")
+    watch_later_dir = mp.command_native({"expand-path",
+        watch_later_dir ~= "" and watch_later_dir or "~~state/watch_later"})


This should be exported as property that uses mp_get_playback_resume_dir for real directory, instead reimplementing the logic here.

github-actions · 2024-12-05T18:34:40Z

Download the artifacts for this pull request:

Windows

macOS

player/command.c

guidocella · 2024-12-05T20:04:22Z

Improved performance by not stating redirect entries, sorting time went from 0.04s to 0.01s with 765 watch later files.

verygoodlee · 2024-12-06T03:55:49Z

In general, played files should be showed in the history regardless of whether the playback has finished or not,
watch later file is not a real history in the sense that it does not save files that have finished playing.

watch later file is only a temporary solution for history, another disadvantage is that it support for the network file is not good, because it only save URL don't save the title, it’s impossible for user to understand https://www.youtube.com/xxx which video is it.

kasper93 · 2024-12-10T13:23:47Z

[select]
[select] stack traceback:
[select]        @select.lua:353: in function 'fn'
[select]        mp.defaults:235: in function 'fn'
[select]        mp.defaults:66: in function 'handler'
[select]        mp.defaults:388: in function 'handler'
[select]        mp.defaults:522: in function 'call_event_handlers'
[select]        mp.defaults:564: in function 'dispatch_events'
[select]        mp.defaults:515: in function <mp.defaults:514>
[select]        [C]: at 0x7ff6a095d0c0
[select]        [C]: at 0x7ff6a095c290
[select] Lua error: bad argument #1 to '?' (string expected, got nil)

guidocella · 2024-12-10T13:33:28Z

Are you trying it without compiling the new current-watch-later-dir property?

kasper93 · 2024-12-10T13:39:24Z

Are you trying it without compiling the new current-watch-later-dir property?

I did checkout and build mpv, so it should be there, no?

guidocella · 2024-12-10T13:47:24Z

Well how to reproduce then? I only get that error if current-watch-later-dir is undefined.

kasper93 · 2024-12-10T13:50:03Z

Well how to reproduce then? I only get that error if current-watch-later-dir is undefined.

--no-config crashes, I don't do anything special.

kasper93 · 2024-12-10T13:53:55Z

player/lua/select.lua

+        show_error("No watch later files with media paths found. " ..
+                   "Enable --write-filename-in-watch-later-config to select recent files.")


This OSD message is too long. It should be concise and easy to read as it disappears fast.

guidocella · 2024-12-10T13:56:05Z

Yeah only --no-config makes the property nil.

kasper93 · 2024-12-10T21:48:38Z

player/lua/select.lua

+    local watch_later_dir = mp.get_property("current-watch-later-dir")
+
+    if not watch_later_dir then
+        show_error("No watch later files found.")


This is warning, not an error. Nothing fails, just is not available.

Every other select binding does this when nothing available though? Do you mean to change to mp.msg.warning?

Select edition shows error only if current-edition is nil, but shows empty list when there are no editions available.

I just feel like, lack of files in history is not an error, so mp.msg.warning. Maybe other indeed could be changed like that. Generally OSD message is enough, but we show also terminal message, errors are scary.

That's not intended. I wrote it blindly and thought no current-edtion means there are no editions like no chapter means there are no chapters in the previous binding.

kasper93 · 2024-12-10T21:48:57Z

player/lua/select.lua

+    end
+
+    if #watch_later_files == 0 then
+        show_error("No watch later files found.")


This is warning, not an error. Nothing fails, just is not available.

kasper93 · 2024-12-10T21:49:00Z

player/lua/select.lua

+    end
+
+    if #recent_files == 0 then
+        show_error("Enable --write-filename-in-watch-later-config to select recent files.")


This is warning, not an error. Nothing fails, just is not available.

This will show, even if this option is enabled, but there is not recent files saved.

It prints No watch later files found. and returns earlier if no recent files are saved. This is specifically if you have watch later files but did not enable --write-filename-in-watch-later-config.

Yes, and it will show all the time until you watch at least two files with this option, enabled. I think it should detect if this option is enabled. Because it was confusing to me to see this error, after enabling this option.

kasper93 · 2024-12-10T21:52:17Z

player/lua/select.lua

+    end
+
+    input.select({
+        prompt = "Select a recent file:",


If I open directory, this will show only one file played as recent from this directory. Also opening this file will open file directly instead of directory.

Doesn't --autocreate-playlist load the other files in the directory if that's what you want?

It will be used in the next commit.

guidocella · 2024-12-13T11:16:42Z

In general, played files should be showed in the history regardless of whether the playback has finished or not, watch later file is not a real history in the sense that it does not save files that have finished playing.

watch later file is only a temporary solution for history, another disadvantage is that it support for the network file is not good, because it only save URL don't save the title, it’s impossible for user to understand https://www.youtube.com/xxx which video is it.

Regarding this I think both watch later files and complete history file are useful in different cases. I also have a minimal script to log watched files to tmpfs just so I can resume from where I was in large directories when I close mpv by accident, while parsing watch later files is useful to check what you need to continue watching. It makes sense to reuse internal watch later files for an internal script. We can bind to g-w for watch later if needed to clarify that it's not a real history, or g-r for resume, but that needs rebinding show-properties.

Showing media-titles would be bad for filenames like 1.jpg instead.

Implement selection of files to resume playing from watch later config files. Requires --write-filename-in-watch-later-config.

kasper93 reviewed Dec 5, 2024

View reviewed changes

guidocella force-pushed the recent branch from 4d4f455 to 0280011 Compare December 5, 2024 18:20

kasper93 reviewed Dec 5, 2024

View reviewed changes

player/command.c Show resolved Hide resolved

guidocella force-pushed the recent branch 2 times, most recently from 4582d9b to 7f2cb9b Compare December 5, 2024 20:03

kasper93 reviewed Dec 10, 2024

View reviewed changes

guidocella force-pushed the recent branch from 7f2cb9b to 496b2d9 Compare December 10, 2024 13:55

guidocella force-pushed the recent branch from 496b2d9 to 2c43fc2 Compare December 10, 2024 13:56

kasper93 reviewed Dec 10, 2024

View reviewed changes

guidocella force-pushed the recent branch 2 times, most recently from 6292fab to ea7e22b Compare December 11, 2024 06:41

guidocella added 2 commits December 13, 2024 10:23

select.lua: use mp.msg.warn for unavailable messages

132faa6

command: add current-watch-later-dir property

90b96d2

It will be used in the next commit.

guidocella force-pushed the recent branch from ea7e22b to 593e0cf Compare December 13, 2024 09:23

guidocella changed the title ~~select.lua: select recent files with g-h~~ select.lua: select files with watch later files with g-w Dec 15, 2024

select.lua: select files with watch later files with g-w

1ff3b95

Implement selection of files to resume playing from watch later config files. Requires --write-filename-in-watch-later-config.

guidocella force-pushed the recent branch from 593e0cf to 1ff3b95 Compare December 15, 2024 14:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

select.lua: select files with watch later files with g-w #15441

select.lua: select files with watch later files with g-w #15441

guidocella commented Dec 5, 2024 •

edited

Loading

kasper93 Dec 5, 2024 •

edited

Loading

github-actions bot commented Dec 5, 2024 •

edited

Loading

guidocella commented Dec 5, 2024

verygoodlee commented Dec 6, 2024

kasper93 commented Dec 10, 2024

guidocella commented Dec 10, 2024

kasper93 commented Dec 10, 2024

guidocella commented Dec 10, 2024

kasper93 commented Dec 10, 2024 •

edited

Loading

kasper93 Dec 10, 2024

guidocella commented Dec 10, 2024

kasper93 Dec 10, 2024

guidocella Dec 10, 2024

kasper93 Dec 10, 2024

guidocella Dec 10, 2024

kasper93 Dec 10, 2024

kasper93 Dec 10, 2024

kasper93 Dec 10, 2024 •

edited

Loading

guidocella Dec 10, 2024

kasper93 Dec 10, 2024

kasper93 Dec 10, 2024

guidocella Dec 10, 2024

guidocella commented Dec 13, 2024

		show_error("No watch later files with media paths found. " ..
		"Enable --write-filename-in-watch-later-config to select recent files.")

select.lua: select files with watch later files with g-w #15441

Are you sure you want to change the base?

select.lua: select files with watch later files with g-w #15441

Conversation

guidocella commented Dec 5, 2024 • edited Loading

kasper93 Dec 5, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Dec 5, 2024 • edited Loading

guidocella commented Dec 5, 2024

verygoodlee commented Dec 6, 2024

kasper93 commented Dec 10, 2024

guidocella commented Dec 10, 2024

kasper93 commented Dec 10, 2024

guidocella commented Dec 10, 2024

kasper93 commented Dec 10, 2024 • edited Loading

Choose a reason for hiding this comment

guidocella commented Dec 10, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kasper93 Dec 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guidocella commented Dec 13, 2024

guidocella commented Dec 5, 2024 •

edited

Loading

kasper93 Dec 5, 2024 •

edited

Loading

github-actions bot commented Dec 5, 2024 •

edited

Loading

kasper93 commented Dec 10, 2024 •

edited

Loading

kasper93 Dec 10, 2024 •

edited

Loading