feat(mcp): wire logging, progress, roots and instructions - #922
Open
venkat-raman17 wants to merge 1 commit into
Open
feat(mcp): wire logging, progress, roots and instructions#922venkat-raman17 wants to merge 1 commit into
venkat-raman17 wants to merge 1 commit into
Conversation
Code Puppy consumes MCP tools only. MCPToolset already supports these, so they are enabled by an optional per-server `capabilities` block in mcp_servers.json. Logs and progress route into the existing per-server file that `/mcp logs` reads, so there is no new UI and nothing under command_line/. Progress answers "is this slow tool call hung?", which stdio servers give no signal for today. Logging and progress default on since they only touch the log file; `instructions` is opt-in because it costs prompt tokens. Bad config keys fall back to defaults rather than failing startup. Also adds safe accessors for handshake metadata, which otherwise raise AttributeError until the toolset is entered. Co-Authored-By: Claude <noreply@anthropic.com>
Author
|
@mpfaffenberger , please review the #PR. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Puppy consumes MCP tools only. MCPToolset already supports these, so they are enabled by an optional per-server
capabilitiesblock in mcp_servers.json.Logs and progress route into the existing per-server file that
/mcp logsreads, so there is no new UI and nothing under command_line/. Progress answers "is this slow tool call hung?", which stdio servers give no signal for today.Logging and progress default on since they only touch the log file;
instructionsis opt-in because it costs prompt tokens. Bad config keys fall back to defaults rather than failing startup.Also adds safe accessors for handshake metadata, which otherwise raise AttributeError until the toolset is entered.