-
-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable viewing locally defined panoramas like the examples #573
base: master
Are you sure you want to change the base?
Conversation
I think this is likely to cause more confusion, since it only works in certain cases. The current error message at least makes it clear why it doesn't work. I also don't want to move I'm going to have to think about this more. |
Have you tested this in Chrome? I can only get it to work in Firefox. |
5a8e431
to
f816411
Compare
As I just wrote on #572, this works with Chrome (and thus also with Chromium) after a further tweak of |
Awesome, you guys seem to be on top of this. How about opening an issue with the chromium, so that in the future they may incorporate this feature without any feature flags. If they do not wanna proceed with this proposal, that's their call, but asking when needed seems to be the next logical thing here. @mpetroff @DDvO what do you think about this. |
…extending hint on possible workarounds
At least at the moment I do not have the time to discuss with Chrome/Chromium developers the underlying security implications, which appear rather intricate. I've just improved the workaround for Pannellum proposed in this pull request. I tested also with other browsers: Safari acts like Firefox (i.e., it does not care), |
Fixes #572 (and likely also #175)