Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable viewing locally defined panoramas like the examples #573

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DDvO
Copy link
Contributor

@DDvO DDvO commented Mar 11, 2018

Fixes #572 (and likely also #175)

@mpetroff
Copy link
Owner

I think this is likely to cause more confusion, since it only works in certain cases. The current error message at least makes it clear why it doesn't work. I also don't want to move pannellum.htm to the root directory.

I'm going to have to think about this more.

@mpetroff
Copy link
Owner

mpetroff commented Apr 4, 2018

Have you tested this in Chrome? I can only get it to work in Firefox.

@DDvO DDvO force-pushed the enable_local_runs branch 2 times, most recently from 5a8e431 to f816411 Compare April 7, 2018 10:04
@DDvO
Copy link
Contributor Author

DDvO commented Apr 7, 2018

As I just wrote on #572, this works with Chrome (and thus also with Chromium) after a further tweak of standalone.js and pannellum.js when it is invoked with the --allow-file-access-from-files command-line option.

@kanalasumant
Copy link

Awesome, you guys seem to be on top of this. How about opening an issue with the chromium, so that in the future they may incorporate this feature without any feature flags. If they do not wanna proceed with this proposal, that's their call, but asking when needed seems to be the next logical thing here. @mpetroff @DDvO what do you think about this.

@DDvO
Copy link
Contributor Author

DDvO commented Apr 8, 2018

At least at the moment I do not have the time to discuss with Chrome/Chromium developers the underlying security implications, which appear rather intricate.

I've just improved the workaround for Pannellum proposed in this pull request.
Now the error message is given only if local file access actually has been denied.

I tested also with other browsers: Safari acts like Firefox (i.e., it does not care),
while Opera behaves like Chrome and provides the same command-line switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants