Try using __builtin_unreachable instead.

mpark · Sep 13, 2017 · 5df16a3 · 5df16a3
1 parent 0a931ef
commit 5df16a3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/include/mpark/config.hpp b/include/mpark/config.hpp
@@ -30,6 +30,10 @@
 #define MPARK_BUILTIN_ADDRESSOF
 #endif
 
+#if __has_builtin(__builtin_unreachable)
+#define MPARK_BUILTIN_UNREACHABLE
+#endif
+
 #if __has_builtin(__type_pack_element)
 #define MPARK_TYPE_PACK_ELEMENT
 #endif

diff --git a/include/mpark/variant.hpp b/include/mpark/variant.hpp
@@ -247,13 +247,9 @@ namespace mpark {
 #ifdef MPARK_EXCEPTIONS
     throw bad_variant_access{};
 #else
-#ifdef __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Winvalid-noreturn"
-#endif
     std::terminate();
-#ifdef __clang__
-#pragma clang diagnostic pop
+#ifdef MPARK_BUILTIN_UNREACHABLE
+    __builtin_unreachable();
 #endif
 #endif
   }