This repository has been archived by the owner on Jun 29, 2023. It is now read-only.
Support for wildlfy 27 #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Willdfly 27 switched from log4jv1 to log4jv2. In practice the only change needed is to point `module.xml` to `org.apache.logging.log4j` instead of `org.apache.log4j`. To make this change backwards compatible we point to both modules optionally. Validated on wildfly 25 (log4jv1) and 27 (log4jv2).
|
I verified that the integrations tests are successful for the following 4 versions of wildfly. While the last 2 will fail without this change. |
|
When can this be merged? I would like to use WF 27+ and use your "official" version. |
|
Thank you for your contribution. That's merged now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Willdfly 27 switched from log4jv1 to log4jv2.
In practice the only change needed is to point
module.xmltoorg.apache.logging.log4jinstead oforg.apache.log4j.To make this change backwards compatible we point to both modules optionally. Validated manually on wildfly 25 (log4jv1) and 27 (log4jv2).