Cjk corpora fixes #937
Draft
Cjk corpora fixes #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is removing a lot of sentences that have exactly the same numbers. Seems that is happenning when the Chinese side has the numbers glued to the Chinese characters.
eu9ene
reviewed
Nov 21, 2024
| @@ -56,14 +83,6 @@ | |||
| }, | |||
| "language": null | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Numbers mismatch was a big problem for our users. It makes translations unreliable and its' hard to catch this issue. I think the right solution here is to fix the Chinese edge case on OpusCleaner side.
There was a problem hiding this comment.
Disable this rule and other rules that can be very tricky and let BCAI do its job is another way. But not sure which one is better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm in progress of having a normalization regex to full-width punctuation. So far I've been able to normalize exclamation mark, question mark and fullstop. I may add more punctuation but commas I do not have a reliable regex because the Chinese comma for enumerations is different than the normal comma. I have doubts whether this is too aggressive or not to apply it for all corpora.