This repository has been archived by the owner on Jun 29, 2018. It is now read-only.
Workaround for IE not seeking to exactly 0 during setup. #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for the issue #453 where IE (11) will not seek to 0 after the first play/pause toggling while setting up the YouTube wrapper.
Without this patch the wrapper is stuck, paused and not seeking, waiting for the current time (as reported by the YT API) to become 0 before firing the ready event. This seems to be related to browser caching as it rarely, if at all, happens when files are first fetched by the browser but it's much more common once the page is reloaded with the caches full.
I also noticed that if calling Popcorn's
currentTime()after the video has been setup (and not yet played) method it would not report 0 unless theplayer.seek( 0 )call was moved to after theplayer.pauseVideo()call.