Handle incomplete destinations in PDF documents where the viewport starts at non-zero coordinates (bug 1913617) #18639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
bug-1913617
branch
from
f27ca2d
to
9205c4f
Compare
Snuffleupagus
changed the title
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4248497196f65a4/output.txt |
…arts at non-zero coordinates (bug 1913617) Hopefully this makes sense, since it doesn't appear to break "proper" PDF documents in my quick testing.
Snuffleupagus
force-pushed
the
bug-1913617
branch
from
9205c4f
to
687c91d
Compare
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/4248497196f65a4/output.txt Total script time: 1.08 mins Published |
|
Could you add an integration test ? |
|
@Snuffleupagus would you be able to provide a basic test case and I'll write the test if you don't have the time to do it ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this makes sense, since it doesn't appear to break "proper" PDF documents in my quick testing.