Add a function that preserves order when extracting stack scripts #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd URLs. Fix import error in the test. Handle cases where domains or URLs are intertwined (e.g. A-B-A-C). This does not deduplicate the list of URLs/domains, it only removes consecutive repeating URLs (e.g. A-A-B will result in A-B).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of script URLs and domains can be useful when analysing and visualizing call stacks. The
get_set_of_script_urls_from_call_stackreturns a set, hence the order information is not available to the caller.This PR adds a function that preserves order when returning the list of script URLs. It only removes consecutive repeating script URLs (e.g. A-A-B-C -> A-B-C).
Fix import error in the test.