Skip to content

Commit

Permalink
Bug 1923703 -Reduce frequency of geckoview performance tests r=kshamp…
Browse files Browse the repository at this point in the history 
…ur,perftest-reviewers,taskgraph-reviewers,bhearsum

Differential Revision: https://phabricator.services.mozilla.com/D229113
  • Loading branch information
@florinbilt
florinbilt committed Dec 4, 2024
1 parent 1ce7152 commit 6fb7c3c
Show file tree
Hide file tree
Showing 4 changed files with 197 additions and 244 deletions.
12 changes: 12 additions & 0 deletions .cron.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,18 @@ jobs:
- {weekday: 'Wednesday', hour: 10, minute: 30}
- {weekday: 'Friday', hour: 10, minute: 30}

- name: geckoview-perftest
job:
type: decision-task
treeherder-symbol: gve-perftests
target-tasks-method: geckoview-perftest
include-push-tasks: true
run-on-projects:
- mozilla-central
when:
- {weekday: 'Monday', hour: 10, minute: 30}
- {weekday: 'Thursday', hour: 10, minute: 30}

- name: custom-car-perf-testing
job:
type: decision-task
Expand Down
74 changes: 31 additions & 43 deletions taskcluster/gecko_taskgraph/target_tasks.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -838,18 +838,9 @@ def filter(task):
if "fenix" in try_name:
if "-power" in try_name:
return True
# Select geckoview resource usage tests

if "geckoview" in try_name:
# Run cpu+memory, and power tests
cpu_n_memory_task = "-cpu" in try_name and "-memory" in try_name
power_task = "-power" in try_name
# Ignore cpu+memory+power tests
if power_task and cpu_n_memory_task:
return False
if cpu_n_memory_task:
return False
if power_task:
return "browsertime" in try_name
return False
# Select browsertime-specific tests
if "browsertime" in try_name:
# Don't run android CaR sp tests as we already have a cron for this.
Expand All @@ -869,6 +860,32 @@ def filter(task):
return [l for l, t in full_task_graph.tasks.items() if filter(t)]


@register_target_task("geckoview-perftest")
def target_tasks_geckoview_perftest(full_task_graph, parameters, graph_config):
"""
Select tasks required for running geckoview tests 2 times a week.
"""

def filter(task):
platform = task.attributes.get("test_platform")
attributes = task.attributes
if attributes.get("unittest_suite") != "raptor":
return False

if accept_raptor_android_build(platform):
try_name = attributes.get("raptor_try_name")
if "geckoview" in try_name and "browsertime" in try_name:
if "hw-s24" in platform and "speedometer" not in try_name:
return False
if "live" in try_name and "cnn-amp" not in try_name:
return False
return True

return False

return [l for l, t in full_task_graph.tasks.items() if filter(t)]


def make_desktop_nightly_filter(platforms):
"""Returns a filter that gets all nightly tasks on the given platform."""

Expand Down Expand Up @@ -1338,22 +1355,8 @@ def filter(task):
if "benchmark" in try_name:
return True
elif accept_raptor_android_build(platform):
# Select browsertime & geckoview specific tests
if "browsertime" and "geckoview" in try_name:
if "power" in try_name:
return False
if "cpu" in try_name:
return False
if "profiling" in try_name:
return False
if "-live" in try_name:
return False
if "speedometer" in try_name:
return True
if "webgl" in try_name:
return True
if "tp6m" in try_name:
return True
return False

return False

Expand Down Expand Up @@ -1404,24 +1407,9 @@ def filter(task):
if "youtube-playback" in try_name:
return True
elif accept_raptor_android_build(platform):
# Select browsertime & geckoview specific tests

if "browsertime" and "geckoview" in try_name:
if "power" in try_name:
return False
if "cpu" in try_name:
return False
if "profiling" in try_name:
return False
if "-live" in try_name:
return False
if "speedometer" in try_name:
return True
if "webgl" in try_name:
return True
if "tp6m" in try_name:
return True
if "youtube-playback" in try_name:
return True
return False

return False

Expand Down
67 changes: 10 additions & 57 deletions taskcluster/kinds/test/browsertime-mobile.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -128,26 +128,7 @@ browsertime-tp6m:
- youtube
run-on-projects:
by-app:
geckoview:
by-variant:
geckoview-no-fission:
by-test-platform:
android-hw-a55.*shippable.*: [trunk-only]
default: []
default:
by-subtest:
wikipedia:
by-test-platform:
android-hw-a55.*shippable.*: []
default: []
google-search-restaurants:
by-test-platform:
android-hw-a55.*shippable.*: []
default: []
default:
by-test-platform:
android-hw-a55.*shippable.*: []
default: []
geckoview: []
fenix:
by-variant:
geckoview-no-fission:
Expand All @@ -174,16 +155,7 @@ browsertime-tp6m-essential:
- [youtube-watch, youtube-w]
run-on-projects:
by-app:
geckoview:
by-subtest:
allrecipes:
by-test-platform:
android-hw-a55.*shippable.*: [trunk]
default: []
default:
by-test-platform:
android-hw-a55.*shippable.*: [trunk-only]
default: []
geckoview: []
fenix:
by-test-platform:
android-hw-a55.*shippable.*: [trunk-only]
Expand Down Expand Up @@ -275,10 +247,7 @@ browsertime-youtube-playback-mobile:
by-test-platform:
android-hw-a55.*shippable.*: [mozilla-central]
default: []
geckoview:
by-test-platform:
android-hw-a55.*shippable.*: [mozilla-central]
default: []
geckoview: []
default: []
max-run-time: 3600

Expand All @@ -301,10 +270,7 @@ browsertime-youtube-playback-power-mobile:
by-test-platform:
android-hw-a55.*shippable.*: [autoland, mozilla-central]
default: []
geckoview:
by-test-platform:
android-hw-a55.*shippable.*: [autoland, mozilla-central]
default: []
geckoview: []
default: []
max-run-time: 1800
mozharness:
Expand Down Expand Up @@ -366,10 +332,7 @@ browsertime-tp6m-live:
by-subtest:
cnn-ampstories:
by-app:
geckoview:
by-test-platform:
android-hw-a55.*shippable.*: [autoland]
default: []
geckoview: []
default: []
default: []
tier: 3
Expand Down Expand Up @@ -414,6 +377,7 @@ browsertime-video-playback-latency-mobile:
run-on-projects:
by-app:
chrome-m: []
geckoview: []
default:
by-test-platform:
android-hw-a55.*shippable.*: [autoland, mozilla-central]
Expand All @@ -434,10 +398,7 @@ browsertime-benchmark-speedometer-mobile:
by-test-platform:
android-hw-a55.*shippable.*: [trunk]
default: []
geckoview:
by-test-platform:
android-hw-a55.*shippable.*: [trunk]
default: []
geckoview: []
cstm-car-m:
by-test-platform:
android-hw-p6.*shippable.*: []
Expand Down Expand Up @@ -468,12 +429,7 @@ browsertime-benchmark-speedometer3-mobile:
android-hw-p6.*shippable.*: [mozilla-central]
android-hw-s24.*shippable.*: [mozilla-central]
default: []
geckoview:
by-test-platform:
android-hw-a55.*shippable.*: [trunk-only]
android-hw-p6.*shippable.*: [mozilla-central]
android-hw-s24.*shippable.*: [mozilla-central]
default: []
geckoview: []
cstm-car-m: [mozilla-central]
chrome-m:
by-test-platform:
Expand All @@ -496,6 +452,7 @@ browsertime-benchmark-motionmark-1-3:
run-on-projects:
by-app:
chrome-m: []
geckoview: []
default:
by-test-platform:
android-hw-a55.*shippable.*: [mozilla-central]
Expand Down Expand Up @@ -538,11 +495,7 @@ browsertime-benchmark-unity-webgl-mobile:
run-on-projects:
by-app:
refbrow: []
geckoview:
by-test-platform:
# Disabled on autoland due to bug 1720063, and bug 1795826
android-hw-a55.*shippable.*: [mozilla-central]
default: []
geckoview: []
default:
by-test-platform:
android-hw-a55.*shippable.*: [mozilla-central]
Expand Down
Loading

0 comments on commit 6fb7c3c

Please sign in to comment.