Bug 1950375 - Remove exclusion for Windows when handling symlinks whi…

…le dealing with PreprocessedFile. r=firefox-build-system-reviewers,sergesanspaille

We used to not use symbolink links on Windows, but that changed a while
back. There was a leftover exclusion causing problems when replacing a
symbolic link with a preprocessed file.

Differential Revision: https://phabricator.services.mozilla.com/D239860

python/mozbuild/mozpack/files.py

@@ -551,10 +551,8 @@ def copy(self, dest, skip_if_older=True):
         # destination is not a symlink, we leave it alone, since we're going to
         # overwrite its contents anyway.
         # If symlinks aren't supported at all, we can skip this step.
-        # See comment in AbsoluteSymlinkFile about Windows.
-        if hasattr(os, "symlink") and platform.system() != "Windows":
-            if os.path.islink(dest.path):
-                os.remove(dest.path)
+        if hasattr(os, "symlink") and os.path.islink(dest.path):
+            os.remove(dest.path)
 
         pp_deps = set(self.extra_depends)