Skip to content

Bug 2040735 - Show FxA email in signed in banner#37

Merged
fterdal merged 3 commits into
mainfrom
bug-2040735-signed-in-banner-email
Jun 11, 2026
Merged

Bug 2040735 - Show FxA email in signed in banner#37
fterdal merged 3 commits into
mainfrom
bug-2040735-signed-in-banner-email

Conversation

@fterdal

@fterdal fterdal commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

We can get the user's email from the FxA social account (under "extra_data"). The email should always be available, but we can still show their FxA id if not.

@fterdal fterdal marked this pull request as ready for review June 9, 2026 15:56
@fterdal

fterdal commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator Author

For QA, I used the local fake FxA OAuth provider. Here are the steps:

  1. Run the app locally, and go to http://localhost:8000/accounts/dummy/login/
  2. Fill in a user id that already exists in the database (use make seed to create some if you want).
  3. Fill in the email and submit.
  4. You'll be taken to the interstitial /auth-complete page with a loading skeleton. Manually navigate to http://localhost:8000/dev-login/
  5. You should see the banner that says "Successfully signed in as [email]"

This banner comes from Django's all-auth package. In general, users should always have an email associated with their account, but if they don't for some reason, we default to their id.

Screenshot 2026-06-09 at 11 57 19 AM

@fterdal fterdal requested a review from nathan-barrett June 9, 2026 16:02

@nathan-barrett nathan-barrett left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ but check in with Dasha if this works for what she was thinking

@fterdal fterdal requested a review from a team as a code owner June 11, 2026 16:15
@fterdal fterdal force-pushed the bug-2040735-signed-in-banner-email branch from 35d2246 to aec34c1 Compare June 11, 2026 16:17

@nathan-barrett nathan-barrett left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approving to get that fxshaving-dev approval

@fterdal fterdal merged commit 4f72417 into main Jun 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants