Bug 2040735 - Show FxA email in signed in banner#37
Merged
Conversation
Collaborator
Author
|
For QA, I used the local fake FxA OAuth provider. Here are the steps:
This banner comes from Django's all-auth package. In general, users should always have an email associated with their account, but if they don't for some reason, we default to their id.
|
nathan-barrett
approved these changes
Jun 10, 2026
nathan-barrett
left a comment
Collaborator
There was a problem hiding this comment.
r+ but check in with Dasha if this works for what she was thinking
…signed-in-banner-email
35d2246 to
aec34c1
Compare
nathan-barrett
approved these changes
Jun 11, 2026
nathan-barrett
left a comment
Collaborator
There was a problem hiding this comment.
re-approving to get that fxshaving-dev approval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

We can get the user's email from the FxA social account (under "extra_data"). The email should always be available, but we can still show their FxA id if not.