Initial integration with test workflow in Cinder staging environment#31
Open
jaredhirsch wants to merge 2 commits into
Open
Initial integration with test workflow in Cinder staging environment#31jaredhirsch wants to merge 2 commits into
jaredhirsch wants to merge 2 commits into
Conversation
You'll need the webhook key and API key to actually run this on the server, the staging keys are in our 1password shared vault. Note that anyone with staging env access can mint new keys as needed. Closes FIDEFE-8522, FIDEFE-8523
Collaborator
There was a problem hiding this comment.
chore: remove the empty file
|
|
||
| # TODO - enqueue a job instead, so we don't block the response on Cinder responding | ||
| try: | ||
| report_link_sharing_quality(share) |
Collaborator
There was a problem hiding this comment.
thought: once we move this to a celery task, we shouldnt have to worry about any transient failures here.
| return share | ||
|
|
||
|
|
||
| def report_link_sharing_quality(share): |
Collaborator
There was a problem hiding this comment.
note: When we add this to the celery task, we should make sure to mock it in conftest.py
Comment on lines
+36
to
+38
| class CinderWebhookIgnoredError(CinderWebhookError): | ||
| """Not an error, a decision we ignore because we already took action, or it's for an entity we don't need to track.""" | ||
|
|
Collaborator
There was a problem hiding this comment.
question: Will we be using this in a followup? I dont see it used currrently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You'll need the webhook key and API key to actually run this on the server, the staging keys are in our 1password shared vault. Note that anyone with staging env access can mint new keys as needed.
Closes FIDEFE-8522, FIDEFE-8523