Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: split start/end dates into separate columns on main list #11989

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: split start/end dates into separate columns on main list #11989

wants to merge 2 commits into from

Conversation

mikewilli
Copy link
Contributor

@mikewilli mikewilli commented Jan 3, 2025 •
edited by RJAK11
Loading

Because

  • start and end date are different fields
  • it would be nice to sort on start/end date separately

This commit

  • splits the start and end dates into separate columns
  • indicates proposed vs actual end date with italics for proposed
  • annotates the NimbusExperiment queryset with a sort_end_date so that we can sort on proposed end date if experiment is live

Fixes #12007

image
image

jaredlockhart
jaredlockhart requested changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep good start, couple thoughts, thnx @mikewilli 🙏

experimenter/experimenter/nimbus_ui_new/templates/nimbus_experiments/table.html Outdated Show resolved Hide resolved
experimenter/experimenter/nimbus_ui_new/views.py Outdated Show resolved Hide resolved
@RJAK11 RJAK11 force-pushed the split-dates-on-experiments-list branch from bc57535 to 20920e0 Compare January 16, 2025 21:26
@RJAK11 RJAK11 marked this pull request as ready for review January 17, 2025 16:42
@RJAK11 RJAK11 requested a review from jaredlockhart January 17, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashikakhurana yashikakhurana Awaiting requested review from yashikakhurana yashikakhurana is a code owner

@brennie brennie Awaiting requested review from brennie brennie is a code owner

@jaredlockhart jaredlockhart Awaiting requested review from jaredlockhart jaredlockhart is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow sort by end date on main experiments list
3 participants
@mikewilli @jaredlockhart @RJAK11