Bug 2038707 - Ensure 'complete' kind never causes dependencies to get…#873
Draft
ahal wants to merge 1 commit into
Draft
Bug 2038707 - Ensure 'complete' kind never causes dependencies to get…#873ahal wants to merge 1 commit into
ahal wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a transform intended to prevent the complete kind from forcing its dependent tasks to be pulled into the graph by converting normal dependencies into if-dependencies.
Changes:
- Insert
gecko_taskgraph.transforms.convert_if_depsinto thecompletekind transform chain. - Introduce a new transform (
convert_if_deps.py) to convertdependenciesintoif-dependencieswhen a per-task flag is enabled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
taskcluster/kinds/complete/kind.yml |
Adds the new transform into the complete kind’s transform pipeline. |
taskcluster/gecko_taskgraph/transforms/convert_if_deps.py |
Implements a new transform to convert dependencies to if-dependencies behind a convert-if-deps flag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+17
to
+19
| if_deps = set(task.setdefault("if-dependencies", set())) | ||
| if_deps.update(deps.values()) | ||
| task["if-dependencies"] = if_deps |
| for task in tasks: | ||
| if (deps := task.get("dependencies")) and task.pop("convert-if-deps", False): | ||
| if_deps = set(task.setdefault("if-dependencies", set())) | ||
| if_deps.update(deps.values()) |
| If `convert-if-deps` is True, converts all dependencies to if-dependencies. | ||
| """ | ||
| for task in tasks: | ||
| if (deps := task.get("dependencies")) and task.pop("convert-if-deps", False): |
Comment on lines
7
to
11
| transforms: | ||
| - taskgraph.transforms.task_context | ||
| - taskgraph.transforms.from_deps | ||
| - gecko_taskgraph.transforms.convert_if_deps | ||
| - gecko_taskgraph.transforms.task |
Comment on lines
+17
to
+18
| if_deps = set(task.setdefault("if-dependencies", set())) | ||
| if_deps.update(deps.values()) |
Member
Author
|
Unfortunately I realized |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… pulled in