Bug 2040381 - Register security event for Access Connector connection error#1121
Open
jporter-dev wants to merge 2 commits into
Open
Bug 2040381 - Register security event for Access Connector connection error#1121jporter-dev wants to merge 2 commits into
jporter-dev wants to merge 2 commits into
Conversation
6c4c9d7 to
30b4daf
Compare
30b4daf to
10d38db
Compare
10d38db to
85185fa
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bugzilla: Bug-2040381
Part 3 of 3. Adds a security event that records when the Access Connector enters an error state because a site failed to load due to a proxy connection error.
access_connector.proxy_errorevent metric with the domain as additional metadata, sent in theenterpriseping.enterprise/metrics.yamlusing theEnterprise Products :: Firefoxtag.data_sensitivity: highly_sensitivesince it sends the browsed domain as an extra key.updatecalls for the same domain while the page remains in the error state.Dependencies / Related Issues
Testing
Steps to verify changes:
Follow steps outlined in #1048
Expected result:
access_connector.proxy_errorevent is submitted to console. Verifiable in either the Browser Toolbox network tab or in the console itself.