Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newline for each field for constexpr field constants #988

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Newline for each field for constexpr field constants #988

merged 2 commits into from
Oct 28, 2024

Conversation

youknowone
Copy link
Contributor

@youknowone youknowone commented Aug 10, 2024 •
edited
Loading

generate newline for each constexpr literal structs' fields

A shared patch to branch #956 and #989

@youknowone youknowone mentioned this pull request Aug 10, 2024
Open
@youknowone youknowone mentioned this pull request Aug 12, 2024
Open
emilio
emilio approved these changes Oct 27, 2024
View reviewed changes
Copy link
Collaborator

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I reviewed this on the other PR. Only issue is this adds trailing whitespace for constexpr expressions which should be removed, but with that fixed, looks good.

@emilio
Copy link
Collaborator

emilio commented Oct 28, 2024

Thanks!

@emilio emilio added this pull request to the merge queue Oct 28, 2024
Merged via the queue into mozilla:master with commit 89a9faa Oct 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio emilio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youknowone @emilio