Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNTOR-3863 and MNTOR-3840 - Fix user dashboard state for manual removal flag #5473

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

codemist
Copy link
Collaborator

@codemist codemist commented Jan 9, 2025

References:

Jira: MNTOR-3853 and MNTOR-3840
Figma:

Description

This PR fixes a few things:

  • A valid dashboard state (so the top banner should have content, not a blank)
  • Toggling the flag on should show 3 data brokers with the removal under maintenance copy in the fixed tab
  • Increase the values in the chart and in the exposure card list description

Screenshot (if applicable)

Screen.Recording.2025-01-09.at.10.48.29.AM.mov

How to test

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug.
  • If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@codemist codemist requested review from Vinnl and flozia January 9, 2025 15:50
Copy link

github-actions bot commented Jan 9, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant