Fix uploadToS3 import path #5472
Open
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e4573d5. It's still being imported from src/scripts/build/uploadAutoCompleteLocations.js, so it can't be plain TypeScript yet.
Also change back to a regular import; I don't think it does much harm to import it when unnecessary, and potentially obfuscates invalid import paths.
Vinnl
commented
Jan 9, 2025
| @@ -27,6 +27,7 @@ import os from "os"; | |||
| import path from "path"; | |||
| import fs from "fs"; | |||
| import AdmZip from "adm-zip"; | |||
| import { uploadToS3 } from "../../utils/s3.js"; | |||
There was a problem hiding this comment.
Note the changed path - but also, @rhelmer, you explicitly made this into a dynamic import here:
Was that just to avoid importing it if not used? Because I think that potentially obscures the path being invalid, so I changed it to a regular import - but let me know if there's another reason.
|
Preview URL 🚀 : https://blurts-server-pr-5472-mgjlpikfea-uk.a.run.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This potentially fixes MNTOR-3922 as well, since the icon upload imported from the
.jsfile:blurts-server/src/scripts/cronjobs/syncBreaches.ts
Line 22 in d91f5a5
I reverted
s3.tsback to a JS file because it was still being imported from the JS upload script. Or at least, it was supposed to, as that had the wrong path.