Update Wagtail/ Smartling integration on the Bedrock side #14935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14935 +/- ##
=======================================
Coverage 77.70% 77.71%
=======================================
Files 161 161
Lines 8380 8382 +2
=======================================
+ Hits 6512 6514 +2
Misses 1868 1868 ☔ View full report in Codecov by Sentry. |
|
@smithellis @escattone I think this changeset will be relevant to SUMO too, particularly the new |
robhudson
approved these changes
Aug 2, 2024
…pen if there's a Snitch URL configured
…uses our base class Instead, it will keep it synchronised with the value of the slug in the source page. This means that we won't get slugs sent to Smartling for translation, either - we don't want that, based on what we've done so far in Bedrock
…he CMS Note that the settings here will require the 0.2.4 release of wagtail-localize-smartling (or greater)
stevejalim
force-pushed
the
update-wagtail-smartling-lang-codes
branch
from
024332c
to
ddf8018
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset tweaks some dials related to the Smartling integration from Wagtail, getting it ready for when we move the VPN Resource Center into Wagtail.
Early review is fine - the only extra commit here will be bumping the version of
wagtail-localize-smartlingDone
slugfield on localized pages from being sent to Smartling, and instead keep it synchronised with the source page's slugwagtail-localize-smartlingto latest version (0.2.4 - due as soon as Apply locale ID mappings consistently wagtail-localize-smartling#16 is updated and merged)Testing
Just eyeballing this changeset is fine - i've tested locally and we'll test lots on Dev, Stage and soon Prod