Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static server healtcheck ping #23178

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

KevinMind
Copy link
Contributor

@KevinMind KevinMind commented Mar 17, 2025

Fixes: mozilla/addons#15458

Context

vite dev server restarts on changes and if there is a critical error the healtcheck should fail and docker should be notified. This gives better visibility as to when and why a static files issue occurs.

Testing

Run in dev mode

rm ./static/js/zamboni/analytics.js && make down && make up DOCKER_TARGET=development

Expect the make up command to fail in the final healtcheck as the static server should be unhealthy.

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
  • Add before and after screenshots (Only for changes that impact the UI).
  • Add or update relevant docs reflecting the changes made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add static server healthcheck monitor
1 participant