Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1908775 - Create a gecko-3/b-linux-gcp-aarch64 worker pool #37

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Bug 1908775 - Create a gecko-3/b-linux-gcp-aarch64 worker pool #37

merged 3 commits into from
Jul 31, 2024

Conversation

gabrielBusta
Copy link
Member

@gabrielBusta gabrielBusta requested review from a team as code owners July 18, 2024 23:04
@gabrielBusta gabrielBusta marked this pull request as draft July 18, 2024 23:08
@gabrielBusta gabrielBusta force-pushed the gecko-3-b-linux-gcp-aarch64 branch 3 times, most recently from c4679b3 to 25bfec3 Compare July 22, 2024 17:28
@gabrielBusta gabrielBusta marked this pull request as ready for review July 22, 2024 17:30
@gabrielBusta gabrielBusta requested a review from jcristau July 22, 2024 17:30
jcristau
jcristau requested changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@jcristau jcristau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you also need a l3 images pool?

worker-pools.yml Outdated
Comment on lines 256 to 259
security:
by-chain-of-trust:
trusted: trusted
default:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unused AFAICT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird! This was failing some check as I was making these changes. But seems like I changed something else that made the error go away.

@gabrielBusta gabrielBusta force-pushed the gecko-3-b-linux-gcp-aarch64 branch from 25bfec3 to cbbba10 Compare July 24, 2024 21:16
@gabrielBusta gabrielBusta requested a review from jcristau July 24, 2024 21:17
@gabrielBusta gabrielBusta merged commit 876a168 into main Jul 31, 2024
11 checks passed
@gabrielBusta gabrielBusta deleted the gecko-3-b-linux-gcp-aarch64 branch July 31, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcristau jcristau jcristau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrielBusta @jcristau