Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1908773 - Create a L1 images-gcp-aarch64 worker pool #36

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

@@ -1119,6 +1119,38 @@ pools:
- *scratch-disk
machine_type: c2-standard-4
capacityPerInstance: 1
- pool_id: '{pool-group}/images-gcp-aarch64'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I add the dind stuff like in images-gcp? I didn't run into anything on try.

This pull-request suggest using these functions resolved the issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't be using dind anywhere nowadays, so let's leave it out.

@gabrielBusta gabrielBusta marked this pull request as ready for review July 18, 2024 22:49
@gabrielBusta gabrielBusta requested review from a team as code owners July 18, 2024 22:49
@gabrielBusta gabrielBusta requested a review from jcristau July 18, 2024 22:49
@gabrielBusta gabrielBusta changed the title Bug 1908773 - Create an images-gcp-aarch64 worker pool Bug 1908773 - Create a L1 images-gcp-aarch64 worker pool Jul 18, 2024
Copy link
Contributor

@jcristau jcristau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gabrielBusta gabrielBusta merged commit dd3762f into main Jul 19, 2024
11 checks passed
@gabrielBusta gabrielBusta deleted the images-gcp-aarch64 branch July 19, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants