Setup checkout cache for code review testing hook

[La0]

Refs mozilla/code-review#2193
Needed for mozilla/code-review#2235

The goal here is to use Taskcluster cache on the firefox-ci code-review testing hook so that mercurial checkouts can be shared amongst tasks.

I'm not sure if I need to declare that scope in grants.yml for the hook or if it's assigned automatically.

[bhearsum]

I'm not sure if I need to declare that scope in grants.yml for the hook or if it's assigned automatically.

As far as I know, this will not happen automatically, and the role certainly doesn't have it already.

[bhearsum]

Requesting changes for the grants.yml part.

[La0]

I added the scope request in hooks.yml relevant part

[bhearsum]

You'll need this in https://github.com/mozilla-releng/fxci-config/blob/main/grants.yml#L2583-L2588 as well (adding it to hooks.yml doesn't change any of the actual grants - it just puts that scope into the hook task itself).

[La0]

Thank you, I added it there too

[La0]

Thanks for the merge & apply @bhearsum

Unfortunately, Taskcluster still complains about missing scopes on that task

[taskcluster:error] Docker configuration could not be created.  This may indicate an authentication error when validating scopes necessary for running the task. 
 Error: Insufficient scopes to attach cache volumes.
The task is missing the following scopes:

[object Object]

This requested devices requires the task scopes to satisfy the following scope expression:
[object Object]

[jcristau]

Seems you're using generic-worker scopes in a docker-worker task, that won't work.

[La0]

Seems you're using generic-worker scopes in a docker-worker task, that won't work.

Thanks for the quick reply ! I though that worker had moved towards generic-worker already.

I'l make another PR to simply request docker-worker cache