Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move taskcluster root url definitions to their own file #223

Merged
merged 1 commit into from
Dec 16, 2024
Merged

refactor: move taskcluster root url definitions to their own file #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions taskcluster/fxci_config_taskgraph/transforms/firefoxci_artifact.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,8 @@

from taskgraph.transforms.base import TransformSequence

from fxci_config_taskgraph.util.integration import (
STAGING_ROOT_URL,
find_tasks,
)
from fxci_config_taskgraph.util.constants import STAGING_ROOT_URL
from fxci_config_taskgraph.util.integration import find_tasks

transforms = TransformSequence()

Expand Down
8 changes: 2 additions & 6 deletions taskcluster/fxci_config_taskgraph/transforms/integration_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,8 @@

from taskgraph.transforms.base import TransformSequence

from fxci_config_taskgraph.util.integration import (
FIREFOXCI_ROOT_URL,
STAGING_ROOT_URL,
find_tasks,
get_taskcluster_client,
)
from fxci_config_taskgraph.util.constants import FIREFOXCI_ROOT_URL, STAGING_ROOT_URL
from fxci_config_taskgraph.util.integration import find_tasks, get_taskcluster_client

transforms = TransformSequence()

Expand Down
2 changes: 2 additions & 0 deletions taskcluster/fxci_config_taskgraph/util/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
FIREFOXCI_ROOT_URL = "https://firefox-ci-tc.services.mozilla.com"
STAGING_ROOT_URL = "https://stage.taskcluster.nonprod.cloudops.mozgcp.net"
3 changes: 1 addition & 2 deletions taskcluster/fxci_config_taskgraph/util/integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@
import requests
import taskcluster

FIREFOXCI_ROOT_URL = "https://firefox-ci-tc.services.mozilla.com"
STAGING_ROOT_URL = "https://stage.taskcluster.nonprod.cloudops.mozgcp.net"
from fxci_config_taskgraph.util.constants import FIREFOXCI_ROOT_URL


@cache
Expand Down
2 changes: 1 addition & 1 deletion taskcluster/scripts/fetch-firefoxci-artifacts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import requests
import taskcluster

from fxci_config_taskgraph.util.integration import FIREFOXCI_ROOT_URL, STAGING_ROOT_URL
from fxci_config_taskgraph.util.constants import FIREFOXCI_ROOT_URL, STAGING_ROOT_URL


def get_firefoxci_credentials() -> dict[str, str]:
Expand Down
7 changes: 2 additions & 5 deletions taskcluster/test/test_transforms_firefoxci_artifact.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,8 @@
from taskgraph.util.templates import merge

from fxci_config_taskgraph.transforms.firefoxci_artifact import transforms
from fxci_config_taskgraph.util.integration import (
FIREFOXCI_ROOT_URL,
STAGING_ROOT_URL,
find_tasks,
)
from fxci_config_taskgraph.util.constants import FIREFOXCI_ROOT_URL, STAGING_ROOT_URL
from fxci_config_taskgraph.util.integration import find_tasks


@pytest.fixture
Expand Down
7 changes: 2 additions & 5 deletions taskcluster/test/test_transforms_integration_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,8 @@
from taskgraph.util.templates import merge

from fxci_config_taskgraph.transforms.integration_test import transforms
from fxci_config_taskgraph.util.integration import (
FIREFOXCI_ROOT_URL,
STAGING_ROOT_URL,
find_tasks,
)
from fxci_config_taskgraph.util.constants import FIREFOXCI_ROOT_URL, STAGING_ROOT_URL
from fxci_config_taskgraph.util.integration import find_tasks


@pytest.fixture
Expand Down
Loading