Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fxa support #183

Merged
merged 4 commits into from
Mar 29, 2018
Merged

Add Fxa support #183

merged 4 commits into from
Mar 29, 2018

Conversation

gdestuynder
Copy link
Contributor

@gdestuynder gdestuynder commented Mar 28, 2018 •
edited
Loading

This bundles #174, which while not ideal is a nice-to-have until we-have-better

@andrew note that this introduces a new msg for the dashboard (mozilla-iam/sso-dashboard#269)

@gdestuynder
Fix 174
d3013b5 
Add default-off rule that denies login for maintenance. Order is 999.
Only use this when required as it forbids ALL logins.

NOTE: This introduce a new message 'maintenancemode' which needs to also
be present on the sso dashboard (it works without, but looks prettier
with)
@gdestuynder
Support newer fxa claims for twofa, picture, etc.
4d21214
@gdestuynder gdestuynder requested a review from jdow March 28, 2018 22:50
@gdestuynder gdestuynder mentioned this pull request Mar 28, 2018
Closed
@gdestuynder gdestuynder mentioned this pull request Mar 28, 2018
Closed
4 tasks
@gdestuynder gdestuynder force-pushed the master branch 2 times, most recently from 1645a10 to 865fc9c Compare March 28, 2018 23:38
@gdestuynder gdestuynder merged commit 7ca80db into mozilla-iam:master Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdow jdow jdow approved these changes

@andrewkrug andrewkrug Awaiting requested review from andrewkrug

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdestuynder @jdow