Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default deny rule to auth0 rules #174

Open
gene1wood opened this issue Feb 15, 2018 · 1 comment
Open

Add default deny rule to auth0 rules #174

gene1wood opened this issue Feb 15, 2018 · 1 comment
Assignees

Comments

@gene1wood
Copy link
Contributor

gene1wood commented Feb 15, 2018

Currently if all auth0 rules were deleted in order to resolve an ordering issue (like what we're doing currently in dev) the absence of any rules would cause sites that use things like AccessRules to allow all authenticated users into the site regardless of group membership. Currently and in the future there could be other rules which effectively deny users from accessing something.

In order to mitigate against this risk, let's make auth0 rules work more like firewally rules by adding a "default deny" rule to run at the very end of the rule order. This would mean that if all other rules were deleted, other than this "default deny" rule, users would be barred from logging in to any site.

The assumption here is that it's better to bar everyone from accessing any site, than to allow an unauthorized user from accessing a site they shouldn't be allowed to.

@gdestuynder suggested this could be accomplished by creating a "default deny" rule and putting it in order position 999 or some such large number.

@gdestuynder
Copy link
Contributor

#175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants