Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observationtraceunfolder update #629

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

sjunges
Copy link
Contributor

@sjunges sjunges commented Nov 11, 2024

  • Update trace unfolder such that it can also support computing reachability probabilities and that conditional probs must be computed via a dedicated routine for conditional probs. The old behavior is available via the "rejectionSamplingMode", which for the time being is the default.
  • Also fix a problem in the belieftracker reset function.

@sjunges sjunges force-pushed the observationtraceunfolder-update branch from 561ca9f to aed5001 Compare December 13, 2024 08:56
@sjunges sjunges requested a review from tquatmann December 13, 2024 08:57
Copy link
Member

@tquatmann tquatmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a very minor suggestion to improve readability a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants