Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iMC changes outside of storm-pars #627

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

linusheck
Copy link
Contributor

@linusheck linusheck commented Nov 1, 2024

Draft PR containing all changes I made for iMC algorithms that are outside of storm-pars. Tests in the storm-pars part (no PR for this yet) cover most lines in this PR.

In more detail, this PR contains:

  • a new function for FlexibleSparseMatrix that adds new rows
  • a SchedulerTrackingHelper for iMCs and a interval (=robust) scheduler index in the minmax solvers for warm-starting
  • interval support for the (Iterative)MinMaxLinearEquationSolver
  • an addNotCurrentModel function for SMT solvers that adds the constraint that the current model is not a solution
  • AGNUM support for Z3
  • interval MC end component elimination (RobustMaximalEndComponentDecomposition, RobustMaximalEndComponent)
  • optimisations in ValueIterationOperator for iMCs
  • a couple more functions for storm::Interval

@linusheck linusheck marked this pull request as ready for review November 19, 2024 09:36
@sjunges
Copy link
Contributor

sjunges commented Nov 28, 2024

Does this depend on #588? That PR is still not ready for merging, is it?

@glatteis
Copy link

glatteis commented Nov 28, 2024

Does this depend on #588? That PR is still not ready for merging, is it?

It doesn’t depend on that PR I‘m pretty sure, because that PR (mainly) changes things in storm-pars. The open discussion was about the behavior of the CLI flag but that is definitely in storm-pars.

@glatteis
Copy link

Ok, I see that there are indeed some changes outside of storm-pars in there, but those are not under discussion :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants