Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove topic name parameters in favor of const topic names #2714

Closed
sjahr opened this issue Feb 28, 2024 · 2 comments · Fixed by #2728
Closed

Remove topic name parameters in favor of const topic names #2714

sjahr opened this issue Feb 28, 2024 · 2 comments · Fixed by #2728
Labels
api API Improvements - type safety, readability, const-ness, testability enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed persistent Allows issues to remain open without automatic stalling and closing.

Comments

@sjahr
Copy link
Contributor

sjahr commented Feb 28, 2024

In multiple places of moveit2 (for example moveit_cpp), topic names can be configured with a parameter. This is not necessary because remapping topics on launch file level is trivial and the parameter API can be simplified by removing these parameters. Instead of having the topic names configurable with a ROS 2 parameters we should just use a const name in the cpp code.
@sjahr sjahr added the enhancement New feature or request label Feb 28, 2024
@sjahr sjahr added help wanted Extra attention is needed good first issue Good for newcomers persistent Allows issues to remain open without automatic stalling and closing. api API Improvements - type safety, readability, const-ness, testability labels Feb 28, 2024
@yash-011
Copy link

yash-011 commented Mar 1, 2024

first issue was good

@Shobuj-Paul Shobuj-Paul mentioned this issue Mar 6, 2024
Merged
6 tasks
@Gaurang-1402 Gaurang-1402 mentioned this issue Mar 31, 2024
Closed
6 tasks
@Gaurang-1402
Copy link

Hi @sjahr I have made a PR to the moveit2 repo that resolves this issue: #2777

I'm curious to hear your feedback and improvise!

@github-project-automation github-project-automation bot moved this to ✅ Done in MoveIt Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api API Improvements - type safety, readability, const-ness, testability enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed persistent Allows issues to remain open without automatic stalling and closing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Const topic instead of parameters Shobuj-Paul/moveit2
3 participants
@sjahr @Gaurang-1402 @yash-011