Skip to content

Fix F1AP compilation by making CHOICE extension members use pointers #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 3, 2025
Merged

Fix F1AP compilation by making CHOICE extension members use pointers #358

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
aa8c670
Initial plan
Copilot Dec 2, 2025
b56f4e1
WIP: Add forward declarations for typedefs to prevent circular depend…
Copilot Dec 2, 2025
ca1fec3
Add forward declarations for typedef references to constructed types
Copilot Dec 2, 2025
d8364f4
Remove unconditional include generation before typedef logic
Copilot Dec 2, 2025
e8a142d
Re-enable rsafe typedef for constructed types
Copilot Dec 2, 2025
05046c2
Make CHOICE extension members use pointers (Option 1)
Copilot Dec 2, 2025
80df83f
Update test expectations for typedef changes
Copilot Dec 2, 2025
6338793
Revert typedef changes, keep only CHOICE extension pointer fix
Copilot Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions libasn1compiler/asn1c_C.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3883,6 +3883,24 @@ expr_break_recursion(arg_t *arg, asn1p_expr_t *expr) {
return 1;
}

/*
* Always make choice-extension members indirect (use pointers) to avoid
* incomplete type errors with complex ASN.1 specifications like F1AP.
* choice-extension members often reference container types that have
* circular dependencies, and using pointers breaks these dependencies.
* Check if identifier starts with "choice" (handles various naming conventions).
*/
if(arg->expr->expr_type == ASN_CONSTR_CHOICE
&& expr->Identifier
&& strncmp(expr->Identifier, "choice", 6) == 0
&& (expr->Identifier[6] == '-' || expr->Identifier[6] == '_')
&& (expr_get_type(arg, expr) & ASN_CONSTR_MASK)
) {
/* Make choice-extension always use indirection */
expr->marker.flags |= EM_INDIRECT | EM_UNRECURSE;
return 1;
}

if((expr->marker.flags & EM_INDIRECT)
|| arg->expr->expr_type == ASN_CONSTR_SET_OF
|| arg->expr->expr_type == ASN_CONSTR_SEQUENCE_OF) {
Expand Down