Scenario based signup for registration and reset password #185
Conversation
Signed-off-by: Nihal LK <[email protected]>
Signed-off-by: Nihal LK <[email protected]>
Signed-off-by: Nihal LK <[email protected]>
Signed-off-by: Nihal LK <[email protected]>
|
Define no of users in the script based on the weightage provided according to the scenario. |
|
Test duration and ramp up duration needs to be added in user defined variables. |
Signed-off-by: Nihal LK <[email protected]>
|
@akhilmoogi , Updated the script as per your reviews |
Signed-off-by: Nihal LK <[email protected]>
|
@nihallakshmankonchady as discussed, support and runtime files path to be mentioned in the script where we are fetching the data from. |
Signed-off-by: Nihal LK <[email protected]>
|
E-signet Signup script peer review is done. As per Anusha's comment mentioned in the confluence page @nihallakshmankonchady has implemented the Asynchronous status call in the script. |
|
To vishwa --- E-signet signup performance scripts have been reviewed from my end. Please once have a review and merge the PR. |
Signed-off-by: Nihal LK <[email protected]>
Signed-off-by: Nihal LK <[email protected]>
Signed-off-by: Nihal LK <[email protected]>
Signed-off-by: Nihal LK <[email protected]>
Signed-off-by: Nihal LK <[email protected]>
Signed-off-by: Nihal LK <[email protected]>
| <jmeterTestPlan version="1.2" properties="5.0" jmeter="5.3"> | ||
| <hashTree> | ||
| <TestPlan guiclass="TestPlanGui" testclass="TestPlan" testname="Test Plan" enabled="true"> | ||
| <stringProp name="TestPlan.comments"></stringProp> |
There was a problem hiding this comment.
"testdata_reset_password.csv" - not sure what convention is followed here
There was a problem hiding this comment.
@vishwa-vyom .. I have renamed to testdata_reset_password.txt.
There was a problem hiding this comment.
the concern is not file extensetion. if snack case is followed, it should be test_data_reset_password.csv or test_data_reset_password.txt
| <stringProp name="TestPlan.comments"></stringProp> | ||
| <boolProp name="TestPlan.functional_mode">false</boolProp> | ||
| <boolProp name="TestPlan.serialize_threadgroups">false</boolProp> | ||
| <elementProp name="TestPlan.user_defined_variables" elementType="Arguments" guiclass="ArgumentsPanel" testclass="Arguments" testname="User Defined Variables" enabled="true"> |
There was a problem hiding this comment.
Varibale was named khmerdata, but our script not specific to any language
There was a problem hiding this comment.
@vishwa-vyom .. I have renamed the variable name to fullnameval.
There was a problem hiding this comment.
fullnameval - camel case not followed. same is for multiple other variable in the "Store Test Data For Reset Password To File" file.
| <elementProp name="protocol" elementType="Argument"> | ||
| <stringProp name="Argument.name">protocol</stringProp> | ||
| <stringProp name="Argument.value">https</stringProp> | ||
| <stringProp name="Argument.metadata">=</stringProp> |
There was a problem hiding this comment.
"Note: Wait for 40 seconds to get status “COMPLETED”, only then pass the request." - this requirement is not taken care for registration flow.
There was a problem hiding this comment.
@vishwa-vyom.. I have added the wait time for registration flow.
There was a problem hiding this comment.
When we always wait for 40 seconds, how we will generate the load of 100 tps ?
There was a problem hiding this comment.
https://mosip.atlassian.net/wiki/spaces/PT/pages/1233453272/eSignet+Signup?focusedCommentId=1352368395 this need to be resolved for this comment.
Signed-off-by: Nihal LK <[email protected]>
Signed-off-by: Nihal LK <[email protected]>
Signed-off-by: Nihal LK <[email protected]>
Signed-off-by: Nihal LK <[email protected]>
| <stringProp name="Argument.name">serverPortNo</stringProp> | ||
| <stringProp name="Argument.value">443</stringProp> | ||
| <stringProp name="Argument.metadata">=</stringProp> | ||
| </elementProp> |
There was a problem hiding this comment.
"Sign Up Service - Reset Password (Setup)" - does not really convey what setup is being done here
| </elementProp> | ||
| <elementProp name="relyingPartyId" elementType="Argument"> | ||
| <stringProp name="Argument.name">relyingPartyId</stringProp> | ||
| <stringProp name="Argument.value">Bharathi-Inc</stringProp> |
There was a problem hiding this comment.
"./support-files/fullNames.txt" - what is the convention followed for naming support files, I see it is not documented in developer guide.
| <stringProp name="Argument.value">Bharathi-Inc</stringProp> | ||
| <stringProp name="Argument.metadata">=</stringProp> | ||
| </elementProp> | ||
| <elementProp name="userClaims" elementType="Argument"> |
There was a problem hiding this comment.
"./bin/RunTimeFiles" - this is not matching according to developer guide
| <jmeterTestPlan version="1.2" properties="5.0" jmeter="5.3"> | ||
| <hashTree> | ||
| <TestPlan guiclass="TestPlanGui" testclass="TestPlan" testname="Test Plan" enabled="true"> | ||
| <stringProp name="TestPlan.comments"></stringProp> |
There was a problem hiding this comment.
the concern is not file extensetion. if snack case is followed, it should be test_data_reset_password.csv or test_data_reset_password.txt
| <stringProp name="TestPlan.comments"></stringProp> | ||
| <boolProp name="TestPlan.functional_mode">false</boolProp> | ||
| <boolProp name="TestPlan.serialize_threadgroups">false</boolProp> | ||
| <elementProp name="TestPlan.user_defined_variables" elementType="Arguments" guiclass="ArgumentsPanel" testclass="Arguments" testname="User Defined Variables" enabled="true"> |
There was a problem hiding this comment.
fullnameval - camel case not followed. same is for multiple other variable in the "Store Test Data For Reset Password To File" file.
| <elementProp name="userClaims" elementType="Argument"> | ||
| <stringProp name="Argument.name">userClaims</stringProp> | ||
| <stringProp name="Argument.value">"name","gender","birthdate","email","phone_number"</stringProp> | ||
| <stringProp name="Argument.metadata">=</stringProp> |
There was a problem hiding this comment.
in "Store Test Data For Reset Password To File", khm is hardcoded and not used from "signUpRegisterLanguage" variable
| <elementProp name="protocol" elementType="Argument"> | ||
| <stringProp name="Argument.name">protocol</stringProp> | ||
| <stringProp name="Argument.value">https</stringProp> | ||
| <stringProp name="Argument.metadata">=</stringProp> |
There was a problem hiding this comment.
When we always wait for 40 seconds, how we will generate the load of 100 tps ?
| <elementProp name="protocol" elementType="Argument"> | ||
| <stringProp name="Argument.name">protocol</stringProp> | ||
| <stringProp name="Argument.value">https</stringProp> | ||
| <stringProp name="Argument.metadata">=</stringProp> |
There was a problem hiding this comment.
https://mosip.atlassian.net/wiki/spaces/PT/pages/1233453272/eSignet+Signup?focusedCommentId=1352368395 this need to be resolved for this comment.
Signed-off-by: Nihal LK <[email protected]>
|
@vishwa-vyom --- E-signet signup performance scripts have been reviewed from my end. Please once have a review and merge the PR. |
Signed-off-by: Nihal LK <[email protected]>
|
@vishwa-vyom I have reviewed the E-signet signup script from my side, kindly review from your side once and merge it. |
|
peer review is approved |
The following files has been added.