Skip to content

Commit

Permalink
Merge pull request #144 from Rakshithb1/release-1.3.x
Browse files Browse the repository at this point in the history
[DSD-3532] Updated Dockerfile
  • Loading branch information
ckm007 authored Aug 13, 2024
2 parents 580ddda + d606f17 commit 7a5646e
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 4 deletions.
16 changes: 13 additions & 3 deletions biosdk-services/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,22 @@ ARG active_profile
# can be passed during Docker build as build time environment for config server URL
ARG spring_config_url

# can be passed during Docker build as build time environment for config server name
ARG spring_cloud_config_name=application,biosdk-service

# can be passed during Docker build as build time environment for spring application name
ARG spring_application_name=biosdk-service

# environment variable to pass github branch to pickup configuration from, at docker runtime
ENV spring_config_label_env=${spring_config_label}
# environment variable to pass active profile such as DEV, QA etc at docker runtime
ENV active_profile_env=${active_profile}
# environment variable to pass spring configuration url, at docker runtime
ENV spring_config_url_env=${spring_config_url}
# environment variable to pass spring config server name, at docker runtime
ENV spring_cloud_config_name_env=${spring_cloud_config_name}
# environment variable to pass spring application name, at docker runtime
ENV spring_application_name_env=${spring_application_name}

ARG biosdk_zip_url

Expand All @@ -36,9 +46,9 @@ ENV biosdk_local_dir_name=${biosdk_local_dir}

ARG sdk_impl

ARG service_context=/biosdk-service
ARG server_servlet_context_path=/biosdk-service

ENV service_context_env=${service_context}
ENV server_servlet_context_path_env=${server_servlet_context_path}

#ENV biosdk_zip_url=$biosdk_zip_url
ENV biosdk_bioapi_impl=${sdk_impl}
Expand Down Expand Up @@ -93,4 +103,4 @@ EXPOSE 9099
ENTRYPOINT ["./configure_biosdk.sh"]

CMD echo $biosdk_bioapi_impl ; \
java -Dloader.path="${loader_path_env}" -Dserver.servlet.context-path="${service_context_env}" -Dspring.cloud.config.label="${spring_config_label_env}" -Dspring.profiles.active="${active_profile_env}" -Dspring.cloud.config.uri="${spring_config_url_env}" --add-modules=ALL-SYSTEM --add-opens java.xml/jdk.xml.internal=ALL-UNNAMED --add-opens java.base/java.lang.reflect=ALL-UNNAMED --add-opens java.base/java.lang.stream=ALL-UNNAMED --add-opens java.base/java.time=ALL-UNNAMED --add-opens java.base/java.time.LocalDate=ALL-UNNAMED --add-opens java.base/java.time.LocalDateTime=ALL-UNNAMED --add-opens java.base/java.time.LocalDateTime.date=ALL-UNNAMED --add-opens java.base/jdk.internal.reflect.DirectMethodHandleAccessor=ALL-UNNAMED -jar biosdk-services.jar
java -Dloader.path="${loader_path_env}" -Dserver.servlet.context-path="${server_servlet_context_path_env}" -Dspring.cloud.config.label="${spring_config_label_env}" -Dspring.profiles.active="${active_profile_env}" -Dspring.cloud.config.uri="${spring_config_url_env}" -Dspring.application.name="${spring_application_name_env}" -Dspring.cloud.config.name="${spring_cloud_config_name_env}" --add-modules=ALL-SYSTEM --add-opens java.xml/jdk.xml.internal=ALL-UNNAMED --add-opens java.base/java.lang.reflect=ALL-UNNAMED --add-opens java.base/java.lang.stream=ALL-UNNAMED --add-opens java.base/java.time=ALL-UNNAMED --add-opens java.base/java.time.LocalDate=ALL-UNNAMED --add-opens java.base/java.time.LocalDateTime=ALL-UNNAMED --add-opens java.base/java.time.LocalDateTime.date=ALL-UNNAMED --add-opens java.base/jdk.internal.reflect.DirectMethodHandleAccessor=ALL-UNNAMED -jar biosdk-services.jar
2 changes: 1 addition & 1 deletion helm/biosdk-service/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ updateStrategy:
## value: "bar"
##
extraEnvVars:
- name: server_servlet_context_env
- name: server_servlet_context_path_env
value: /biosdk-service
- name: spring_application_name_env
value: biosdk-service
Expand Down

0 comments on commit 7a5646e

Please sign in to comment.