Add split_eval_set command #1609
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jimmy Xu <[email protected]>
jimmyxu-db
commented
Oct 25, 2024
dakinggg
reviewed
Oct 25, 2024
mattyding
reviewed
Oct 25, 2024
Signed-off-by: Jimmy Xu <[email protected]>
Signed-off-by: Jimmy Xu <[email protected]>
Signed-off-by: Jimmy Xu <[email protected]>
|
Please also add a PR description (describing the functionality added, not any downstream API needs). |
Signed-off-by: Jimmy Xu <[email protected]>
Signed-off-by: Jimmy Xu <[email protected]>
Signed-off-by: Jimmy Xu <[email protected]>
dakinggg
reviewed
Oct 29, 2024
|
|
||
| log = logging.getLogger(__name__) | ||
|
|
||
| LOCAL_PATH = 'tmp-t' |
There was a problem hiding this comment.
I don't think you want to hardcode this. Should this not just be a fallback to assume local path?
There was a problem hiding this comment.
im not too familiar, is it acceptable to have
if remote object store:
remote object store:
else:
local path
i.e. have it be the defualt?
There was a problem hiding this comment.
seems ok? just note that is what it defaults to
Signed-off-by: Jimmy Xu <[email protected]>
Signed-off-by: Jimmy Xu <[email protected]>
Signed-off-by: Jimmy Xu <[email protected]>
Signed-off-by: Jimmy Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.