Skip to content

Fix autoresume with non-default CheckpointSaver. #3919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −3
Open

Fix autoresume with non-default CheckpointSaver. #3919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions composer/trainer/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1375,9 +1375,13 @@ def __init__(
log.info('Multiple CheckpointSaver provided as callbacks. Using the first one as reference.')
self._checkpoint_saver = _checkpoint_savers[0]

if self._checkpoint_saver.folder != save_folder:
log.info(f'Using {self._checkpoint_saver.folder} as save_folder.')
save_folder = self._checkpoint_saver.folder
if self._checkpoint_saver.remote_uploader:
checkpoint_saver_folder = self._checkpoint_saver.remote_uploader.remote_folder
else:
checkpoint_saver_folder = self._checkpoint_saver.folder
if checkpoint_saver_folder != save_folder:
log.info(f'Using {checkpoint_saver_folder} as save_folder.')
save_folder = checkpoint_saver_folder

if self._checkpoint_saver.latest_filename is None:
save_latest_filename = None
Expand Down