Skip to content

Make it possible to define the root temporary directory for composer #3784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Make it possible to define the root temporary directory for composer #3784

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02731ca
Using TMPDIR env var as a temporary directory. If it's not set, check…
mshtelma Mar 19, 2025
83dcd95
Formatting
mshtelma Mar 19, 2025
ae174ee
Formatting
mshtelma Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion composer/callbacks/checkpoint_saver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,13 @@ def __init__(

is_remote_folder = backend != ''
if is_remote_folder: # If uploading to a remote path, use a temporary directory to save local checkpoints.
local_folder = os.path.join(tempfile.mkdtemp(), local_folder)
root_temp_folder = None
Copy link
Contributor

@dakinggg dakinggg Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is already how mkdtemp works? https://docs.python.org/3/library/tempfile.html#tempfile.mkdtemp. The first place it should look to decide the tmpdir folder is whatever is specified by the TMPDIR env var.

if os.environ.get('TMPDIR') is not None:
root_temp_folder = os.environ.get('TMPDIR')
elif os.path.exists('/local_disk0/'): # Probably we are on MLR, so we have to use /local_disk0
root_temp_folder = '/local_disk0/temp'
os.makedirs(root_temp_folder, exist_ok=True)
local_folder = os.path.join(tempfile.mkdtemp(prefix=root_temp_folder), local_folder)

filename = str(filename)
remote_file_name = str(remote_file_name) if remote_file_name is not None else None
Expand Down
Loading