refactor: sign in, sign out. (#199)

morganney · Feb 6, 2024 · c206c96 · c206c96
1 parent bb9bb29
commit c206c96
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 15 deletions.
diff --git a/packages/ui/src/components/busmap.tsx b/packages/ui/src/components/busmap.tsx
@@ -36,9 +36,8 @@ const BusmapPage: FC = () => {
           <PageTabButton page="select">Selector</PageTabButton> tab to find a transit
           agency, route, direction, and stop that fits your itinerary. Alternatively, you
           can use the <PageTabButton page="locate">Nearby</PageTabButton> tab where you
-          will be prompted to permit your device to share its geolocation with Busmap, and
-          a list of the nearest stops for currently running transit agencies will be
-          displayed.
+          will be prompted to share your device&apos;s geolocation with Busmap, and a list
+          of the nearest stops will be displayed.
         </p>
         <p>
           From either option, you can favorite the stop by clicking the star ⭐ icon, and

diff --git a/packages/ui/src/components/home.tsx b/packages/ui/src/components/home.tsx
@@ -133,7 +133,7 @@ const Home: FC = () => {
         const touchEndX = touches[0].pageX
 
         // Allow a small fudge factor
-        if (Math.abs(touchEndX - state.touchStartX) > 15) {
+        if (Math.abs(touchEndX - state.touchStartX) > 100) {
           // Close
           if (touchEndX < state.touchStartX) {
             globalDispatch({ type: 'collapsed', value: true })

diff --git a/packages/ui/src/components/navigation.tsx b/packages/ui/src/components/navigation.tsx
@@ -134,7 +134,7 @@ const Nav = styled.nav<{ mode: Mode; isSignedIn: boolean }>`
     display: ${({ isSignedIn }) => (isSignedIn ? 'none' : 'list-item')};
 
     button {
-      padding: 3px 5px;
+      padding: 5px;
       white-space: nowrap;
       flex-direction: row;
       justify-content: center;

diff --git a/packages/ui/src/components/page.tsx b/packages/ui/src/components/page.tsx
@@ -23,7 +23,7 @@ const Section = styled.section`
 
   p {
     margin: 0;
-    line-height: 1.5;
+    line-height: 1.35;
   }
 `
 const Page: FC<PageProps> = ({ title, children, className, loading = false }) => {

diff --git a/packages/ui/src/components/profile.tsx b/packages/ui/src/components/profile.tsx
@@ -83,9 +83,11 @@ const Profile: FC = () => {
       dispatch({ type: 'user', value: undefined })
       dispatch({ type: 'agency', value: undefined })
       dispatchStorage({ type: 'favoriteReset' })
-      toast({ type: 'info', message: `Goodbye ${result.user.givenName ?? ''}.` })
       document.body.classList.remove('busmap-loaded')
       navigate('/')
+      setTimeout(() => {
+        toast({ type: 'info', message: `Goodbye ${result.user.givenName ?? ''}.` })
+      }, 350)
     } catch {
       toast({ type: 'error', message: 'Error signing out!' })
     } finally {

diff --git a/packages/ui/src/components/signIn.tsx b/packages/ui/src/components/signIn.tsx
@@ -49,10 +49,6 @@ const SignIn: FC = () => {
         callback: async response => {
           setLoading(true)
 
-          if (ref.current) {
-            ref.current.style.setProperty('display', 'none')
-          }
-
           try {
             const user = await login(response.credential)
             const riderFavs = await getFavorites()
@@ -66,10 +62,6 @@ const SignIn: FC = () => {
             toast({ type: 'error', message: 'Error signing in.' })
           } finally {
             setLoading(false)
-
-            if (ref.current) {
-              ref.current.style.setProperty('display', 'block')
-            }
           }
         }
       })

diff --git a/packages/ui/src/global.css b/packages/ui/src/global.css
@@ -263,3 +263,7 @@ body.busmap-dark .busmap-vehicle::before {
   align-items: center;
   justify-content: center;
 }
+/* without, scrollbars appear after sign in. */
+#g_a11y_announcement {
+  display: none;
+}