add arm64 build #1634
Open
add arm64 build #1634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tipputhynhean
commented
Jul 31, 2025
tipputhynhean
commented
- Adding arm64 build
|
Can we use Github's ARM runners instead? |
tipputhynhean
force-pushed
the
add-arm64
branch
from
a49c93d to
a269c09
Compare
|
@adamdecaf Updated, please check. I'm not sure if I can clean up the docker and docker-hub in |
adamdecaf
reviewed
Aug 8, 2025
|
Can we leverage the makefile to run docker commands? That is a lot cleaner and we already read VERSION, so we don't need to duplicate that logic. The existing task can append the arch suffix, which can come from the action step if it's easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.