-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced Pseudos:keys and new Pseudos:stop #245
base: master
Are you sure you want to change the base?
Conversation
…p , prevents propagation of events directly from the pseudo - updated docs - added more specs for both Pseudos:keys and new Pseudos:stop
I like the extension to Keyboard, but I dislike the :stop pseudo. It's a good idea but we shouldn't encourage our users to use |
Pretty sweet! Usually I just use |
Usually when you say |
#234 anyone? |
…udos:stop , prevents propagation of events directly from the pseudo - updated docs - added more specs for both Pseudos:keys and new Pseudos:stop" This reverts commit 418800c.
…d :preventDefault - added Specs for all 3 pseudos - updated docs
I have reverted my multiple keys support on the |
I approve |
@arian then merge it |
@cpojer: what do you think i'm doing? On Fri, May 27, 2011 at 12:48 PM, cpojer
|
blerg to merges. |
Specifically this branch. |
I just pulled w00fz' pseudos on top of my branch. I did another commit, which I think is a good idea. I think that if we're going to add these pseudos, it's a good idea to make them a bit more flexible and check the first argument. If you guys don't agree, I can obviously push without that commit. Specs seem to pass in Chrome. |
I'm totally fine with it. Although most of the times it's a true check it gives some more flexibility which is good and does cost nothing. // Djamil Legato On Jun 6, 2011, at 12:08 AM, timwienk [email protected] wrote:
|
@timwienk, @w00fz, @seanmonstar: what's the status of this? is it pushable? |
The Pseudos:keys now supports multiple key combinations
element.addEvent('keydown:keys('shift+a, ,, delete, esc', myFun);
and there's a new Pseudos:stopelement.addEvent('click:stop', myFun);