Fog of war mechanic (Bandit) #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellan-simiotics
requested changes
Apr 2, 2024
| error WaitForNFTTick(address tokenAddress, uint256 tokenID); | ||
| error NFTNotOwnedByPlayer(address player, address tokenAddress, uint256 tokenID); | ||
|
|
||
| function _preRollForNFT(address tokenAddress, uint256 tokenID) internal virtual {} |
There was a problem hiding this comment.
Should there also be a preRollForPlayer ?
There was a problem hiding this comment.
Added a comment clarifying why there isn't symmetry between player and NFT - NFT has preroll, but player doesn't.
| vm.roll(block.number + blockDeadline + 1); | ||
| vm.expectRevert(abi.encodeWithSelector(Bandit.NFTDeadlineExceeded.selector, address(nfts), tokenID)); | ||
| bandit.resolveForNFT(address(nfts), tokenID); | ||
| vm.stopPrank(); |
There was a problem hiding this comment.
Is this test supposed to rerollForNFT ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the single player fog of war mechanic that we will be using in The Degen Trail.