Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added raised error. #1080

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added raised error. #1080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5315b52
Added raised error.
Jun 4, 2024
d5ba535
Add error handler.
Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions engineapi/engineapi/actions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,10 @@ class LeaderboardAssignResourceError(Exception):
pass


class LeaderboardPushScoreError(Exception):
pass


BATCH_SIGNATURE_PAGE_SIZE = 500

logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -1717,6 +1721,7 @@ def add_scores(
db_session.commit()
except:
db_session.rollback()
raise LeaderboardPushScoreError("Error committing scores")

return leaderboard_scores

Expand Down
6 changes: 6 additions & 0 deletions engineapi/engineapi/routes/leaderboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,6 +779,12 @@ async def leaderboard_push_scores(
status_code=500,
detail=f"Delete scores failed.",
)
except actions.LeaderboardPushScoreError as e:
logger.error(f"Add scores failed with error: {e}")
raise EngineHTTPException(
status_code=500,
detail=f"Add scores failed.",
)
except Exception as e:
logger.error(f"Score update failed with error: {e}")
raise EngineHTTPException(status_code=500, detail="Score update failed.")
Expand Down
Loading