-
Notifications
You must be signed in to change notification settings - Fork 28
feat: Add Universal Theming Classes #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
redstonekasi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine-ish in terms of code to me. I'd change the patch replacement to be as minified as possible, this sometimes aids in compatibility between different extensions.
The one concern I do have is about the necessity of this plugin, CSS selectors can already do what this plugin accomplishes without much trouble. We do not have any policies in place that would prevent this extension from being submitted so don't consider this a disapproval, just something to consider.
|
I personally want to see the stance of the other aforementioned mods before deciding to try and spearhead this knowing that there is a chance that very few are going to use it |
Yeah, I did say "Helps with theming by removing the need for wildcard selectors, which also improves performance."
I am waiting for that as well before try and add this to BD/Shelter |
This didn't used to be the case and is an upstream Chromium issue ever since like around 132.x.x.x. The problem is I doubt they would care to try and fix it because "yOu'Re NoT sUpPoSeD tO uSe AdVaNcEd SeLeCtOrS" for normal webdev. |
well using them with has and similar functions will cause lag no matter what. unless you use |
|
:has() has always been a performance issue, which is why it took years for it to even get mainstreamed. |
CSS Snippet if you wanna try this extension |
Adds UTC (Universal Theming Classes) that appends stable class names [For example
utc_xyz] to elements, so theme devs don’t have to worry about class rerolls, only structural changes.Helps with theming by removing the need for wildcard selectors, which also improves performance.
The idea is to get it adopted across other client mods too, to make theming easier and consistent. Already PR'ed at replugged and vencord.