Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deno example with wasm-gc #183

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mizchi
Copy link

@mizchi mizchi commented Apr 16, 2024

tl;dr

Add examples/deno. It works with --target wasm-gc without browser.

Why

wasm-gc was a helpful sample, but the browser setup was somewhat cumbersome.

The addition of WebAssembly for browser-compatible deno is an example of how moonbit can be used.

@mizchi mizchi changed the title Add deno with wasm-gc example Add deno example with wasm-gc Apr 16, 2024
@peter-jerry-ye
Copy link
Collaborator

I would argue that we can just extract the js part from index.html to a main.mjs and achieve the same effect with the wasm-gc example.

Also I think we would need to determine the license of the project before accepting such a PR @bobzhang

@mizchi
Copy link
Author

mizchi commented Apr 19, 2024

In fact, yes. However, many people are unaware of it without samples, so just having it on the examples list as a use case makes sense.
(I can't deny that I am a fan of deno myself.)

@peter-jerry-ye
Copy link
Collaborator

I adjusted the example in #186 for deno and node. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants