Add Array::windows

[MINGtoMING]

Add Array::windows.

[peter-jerry-ye-code-review]

Missing input validation for window size parameter

Category
Correctness
Code Snippet
pub fn[T] Array::windows(self : Array[T], size : Int) -> Array[ArrayView[T]] {
let len = self.length() - size + 1
Recommendation
Add validation to check if size > 0 at the start of the function
Reasoning
The documentation states that size must be positive, but the code doesn't enforce this. Negative or zero size could lead to unexpected behavior or runtime errors.

Potential memory pre-allocation optimization

Category
Performance
Code Snippet
let windows = Array::new(capacity=len)
for i in 0..<len {
windows.push(self[i:i + size])
Recommendation
Good use of capacity pre-allocation. Consider adding a comment explaining why len is the optimal capacity.
Reasoning
While the code correctly pre-allocates capacity, documenting this optimization would help maintainers understand the performance consideration.

Test case could be more comprehensive

Category
Maintainability
Code Snippet
test "array_windows" {
let arr = [1, 2, 3, 4, 5, 6]
let windows = arr.windows(11)
Recommendation
Add test cases for window size = array length and edge case window size = 0
Reasoning
While current tests cover basic cases, including edge cases like window size equal to array length would improve test coverage and documentation of behavior.

[coveralls]

Pull Request Test Coverage Report for Build 7004

Details

• 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.01%) to 92.521%

---

Totals
Change from base Build 7003:	0.01%
Covered Lines:	8746
Relevant Lines:	9453

---

💛 - Coveralls

[FlyCloudC]

How about return an Array[ArrayView[T]]?

[MINGtoMING]

I agree. Array::windows is typically used in read-only scenarios as well. However, the func interface differs from existing chunks/chunk_by impl, so perhaps they need to be adjusted together.