remove evm signer from getSourceData

moonbeam-foundation · May 28, 2024 · 9f2fbb8 · 9f2fbb8
1 parent c6331e4
commit 9f2fbb8
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 15 deletions.
diff --git a/packages/sdk/src/getTransferData/getDestinationData.ts b/packages/sdk/src/getTransferData/getDestinationData.ts
@@ -4,20 +4,18 @@ import { TransferConfig } from '@moonbeam-network/xcm-config';
 import { AssetAmount } from '@moonbeam-network/xcm-types';
 import { toBigInt } from '@moonbeam-network/xcm-utils';
 import { PolkadotService } from '../polkadot';
-import { DestinationChainTransferData, EvmSigner } from '../sdk.interfaces';
+import { DestinationChainTransferData } from '../sdk.interfaces';
 import { getBalance, getDecimals, getMin } from './getTransferData.utils';
 
 export interface GetDestinationDataParams {
   transferConfig: TransferConfig;
   destinationAddress: string;
-  evmSigner?: EvmSigner;
   polkadot: PolkadotService;
 }
 
 export async function getDestinationData({
   transferConfig,
   destinationAddress,
-  evmSigner,
   polkadot,
 }: GetDestinationDataParams): Promise<DestinationChainTransferData> {
   const {
@@ -50,7 +48,6 @@ export async function getDestinationData({
   const feeAmount = await getFee({
     address: destinationAddress,
     config: transferConfig,
-    evmSigner,
     polkadot,
   });
   const minAmount = zeroAmount.copyWith({ amount: min });
@@ -66,7 +63,6 @@ export async function getDestinationData({
 export interface GetFeeParams {
   address: string;
   config: TransferConfig;
-  evmSigner?: EvmSigner;
   polkadot: PolkadotService;
 }
 

diff --git a/packages/sdk/src/getTransferData/getSourceData.ts b/packages/sdk/src/getTransferData/getSourceData.ts
@@ -40,7 +40,6 @@ export async function getSourceData({
   transferConfig,
   destinationAddress,
   destinationFee,
-  evmSigner,
   polkadot,
   sourceAddress,
 }: GetSourceDataParams): Promise<SourceChainTransferData> {
@@ -55,7 +54,6 @@ export async function getSourceData({
       address: destinationAddress,
       chain,
       config,
-      evmSigner,
       polkadot,
     }),
   });
@@ -67,7 +65,6 @@ export async function getSourceData({
           asset: config.fee.asset,
           chain,
           config,
-          evmSigner,
           polkadot,
         }),
       })
@@ -80,7 +77,6 @@ export async function getSourceData({
           asset: config.destinationFee.asset,
           chain,
           config,
-          evmSigner,
           polkadot,
         }),
       })
@@ -91,7 +87,6 @@ export async function getSourceData({
     chain,
     config,
     decimals: zeroAmount.decimals,
-    evmSigner,
     polkadot,
   });
 
@@ -150,7 +145,6 @@ export async function getSourceData({
     decimals: zeroFeeAmount.decimals,
     destinationFeeBalanceAmount,
     destinationFeeConfig: config.destinationFee,
-    evmSigner,
     extrinsic,
     feeConfig: config.fee,
     polkadot,

diff --git a/packages/sdk/src/getTransferData/getTransferData.ts b/packages/sdk/src/getTransferData/getTransferData.ts
@@ -21,6 +21,7 @@ export interface GetTransferDataParams extends Partial<Signers> {
   transferConfig: TransferConfig;
 }
 
+// TODO: make getTransferData work with EvmSigner and PolkadotSigner
 export async function getTransferData({
   configService,
   destinationAddress,
@@ -36,7 +37,6 @@ export async function getTransferData({
 
   const destination = await getDestinationData({
     destinationAddress,
-    evmSigner,
     polkadot: destPolkadot,
     transferConfig,
   });
@@ -49,7 +49,6 @@ export async function getTransferData({
   const source = await getSourceData({
     destinationAddress,
     destinationFee,
-    evmSigner,
     polkadot: srcPolkadot,
     sourceAddress,
     transferConfig,

diff --git a/packages/sdk/src/getTransferData/getTransferData.utils.ts b/packages/sdk/src/getTransferData/getTransferData.utils.ts
@@ -7,15 +7,13 @@ import {
   createContractWithoutSigner,
 } from '../contract';
 import { PolkadotService } from '../polkadot';
-import { EvmSigner } from '../sdk.interfaces';
 
 export interface GetBalancesParams {
   address: string;
   asset?: Asset;
   chain: AnyChain;
   config: AssetConfig;
   decimals: number;
-  evmSigner?: EvmSigner;
   polkadot: PolkadotService;
 }