Foreign assets creation via token reserve #3104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzamontiel
changed the title
gonzamontiel
added
D9-needsaudit👮
WASM runtime size check:Compared to target branchMoonbase runtime: 2280 KB (no changes) ✅ Moonbeam runtime: 2260 KB (no changes) ✅ Moonriver runtime: 2264 KB (no changes) ✅ Compared to latest release (runtime-3400)Moonbase runtime: 2280 KB (+252 KB compared to latest release) Moonbeam runtime: 2260 KB (+248 KB compared to latest release) Moonriver runtime: 2264 KB (+252 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master gonza/foreign-assets-via-token-lock +/- ##
======================================================================
Coverage 74.49% 74.49% 0.00%
Files 375 375
+ Lines 95313 95407 +94
======================================================================
+ Hits 70998 71066 +68
+ Misses 24315 24341 +26
|
RomarQ
requested changes
Jan 8, 2025
| @@ -121,7 +122,7 @@ pub mod pallet { | |||
| pub const PALLET_ID: frame_support::PalletId = frame_support::PalletId(*b"forgasst"); | |||
|
|
|||
| #[pallet::config] | |||
| pub trait Config: frame_system::Config + pallet_evm::Config { | |||
| pub trait Config: frame_system::Config + pallet_evm::Config + scale_info::TypeInfo { | |||
There was a problem hiding this comment.
Suggested change
| pub trait Config: frame_system::Config + pallet_evm::Config + scale_info::TypeInfo { | |
| pub trait Config: frame_system::Config + pallet_evm::Config { |
| @@ -75,6 +76,11 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> { | |||
| .saturating_add(T::DbWeight::get().reads(2_u64)) | |||
| .saturating_add(T::DbWeight::get().writes(3_u64)) | |||
| } | |||
|
|
|||
| fn create_foreign_asset_reserve() -> Weight { | |||
| Weight::default() | |||
There was a problem hiding this comment.
We should use proper weights, generating it with release profile is file.
Comment on lines
+406
to
410
| .tx.sudo.sudoAs( | ||
| alith.address, | ||
| context | ||
| .polkadotJs() | ||
| .tx.evmForeignAssets.createForeignAsset(assetId, xcmLoc, decimals, symbol, name) |
There was a problem hiding this comment.
We can do a normal call as Alith
Suggested change
| .tx.sudo.sudoAs( | |
| alith.address, | |
| context | |
| .polkadotJs() | |
| .tx.evmForeignAssets.createForeignAsset(assetId, xcmLoc, decimals, symbol, name) | |
| .tx.evmForeignAssets.createForeignAsset(assetId, xcmLoc, decimals, symbol, name) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
create_foreign_assetso that reserves a deposit from the user to be able to create a new foreign assetForeignAssetCreationDepositcreate_foreign_assetcan be executed by any account, by making a deposit in the native token.Disclaimer: the pallet is not in use and the functionality wasn't exposed publicly AFAIK. The changes are still breaking, but most likely harmless.
TODO
What important points reviewers should know?
Some assumptions were made considering the current state of the pallet:
AssetOwnerwas meant initially to be a descriptive enum of the possible sources of creation of an asset, but since there were no assets yet created, we only need to distinguish between migrated assets, and the ones created from now on (any account). Naming in this enum might be improved.Is there something left for follow-up PRs?
What alternative implementations were considered?
Using Fungibles was investigated, but the implementation uses ReservableCurrency, following the same pattern as pallet assets.
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
We should run the migration added here #3020 after this PR is merged.
What value does it bring to the blockchain users?
It should be easier for Parachain teams to register their assets natively in Moonbeam