Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow viem client as EVM signer in xcm-sdk #746

Conversation

mmaurello
Copy link
Contributor

@mmaurello mmaurello commented Sep 12, 2023

Description

With the latest xcm-sdk version, we allow viem's WalletClient as a signer. Since there is an ongoing tendency for replacing ethers for viem

Checklist

  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • If pages have been moved around, I have created an additional PR in moonbeam-mkdocs to update redirects
  • If pages have been moved around, I have run the move-pages.py script to move the pages and update the image paths on the chinese repo
    • After the script has been run, I have created an additional PR in moonbeam-docs-cn
  • If images have been added, I have run the compress-images.py script to compress the images.
  • If variables (in variables.yml) need to be updated (such as a name change), I have updated the moonbeam-docs-cn repo to use the new variables
  • If this page requires a disclaimer, I have added one

Corresponding PRs

moonbeam-foundation/xcm-sdk#131

After Translation Requirements

  • Will need to create PR in moonbeam-docs repo to remove images
  • Will need to create PR in moonbeam-docs repo to remove variables
  • Will need to create PR in moonbeam-mkdocs repo to add redirects for Chinese site
  • No additional PRs are required after the translations are done

Items to be Updated

n/a

@eshaben eshaben changed the base branch from master to eshaben/allow-viem-client September 14, 2023 20:40
@eshaben eshaben merged commit 1d5f89e into moonbeam-foundation:eshaben/allow-viem-client Sep 14, 2023
1 check passed
@eshaben
Copy link
Contributor

eshaben commented Sep 14, 2023

Thanks @mmaurello!!

@eshaben eshaben added the A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) label Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants