Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook for certificate element classes discovery #63

Open
wants to merge 1 commit into
base: MOODLE_400_STABLE
Choose a base branch
from

Conversation

skodak
Copy link
Contributor

@skodak skodak commented Jun 24, 2024

Hi Marina,

I am maintaining a few certificate elements which is a bit annoying because Modole plugin database does not even support this subplugin type (last time I checked).

So I was thinking if it would be possible to add support for discovery of additional elements from other plugins via hooks, turns out it was pretty simple, see the small patch.

What do you think?

@skodak skodak force-pushed the elementshook branch 4 times, most recently from 7acb211 to f93c8ad Compare June 24, 2024 15:28
@marinaglancy
Copy link
Contributor

Hi Petr,
thanks for the suggestion. I wish we had hooks before, we would not even need the certificateelement plugin type.

Can you please create an issue in the tracker, we have a WPOS project and "Certificates" component in it:
https://tracker.moodle.org/issues/?jql=project%20%3D%20WPOS%20AND%20component%20%3D%20Certificates

Workplace team developers who are responsible for the certificate component will be able to comment there. Unfortunately, they do not receive notifications from github, this is only a mirror of our dev repo. Thanks

@skodak
Copy link
Contributor Author

skodak commented Jun 24, 2024

hi Marina, Moodle disabled my tracker account, I cannot create any issues, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants