Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert SKBitmap.Encode with SKPngEncoderOptions to previous behavior (2.88.8) #3014

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sungaila
Copy link

Description of Change

Reverts SKBitmap.Encode to previous behavior to use default PNG compression.

Until 2.88.8: ZLibLevel 6 is used for PNG compression.
Since 3.0.0: ZLibLevel 0 is used for PNG compression.

Bugs Fixed

API Changes

None.

Behavioral Changes

Calling SKBitmap.Encode or SKPixmap.Encode (SKWStream, SKEncodedImageFormat, int) will result in a default PNG compression level (as in 2.88.8). The SKPngEncoderFilterFlags are unchanged.

Required skia PR

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Merged related skia PRs
  • Changes adhere to coding standard
  • Updated documentation

Copy link
Contributor

Hey there @sungaila! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@sungaila

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 3.0.0 regression for PNG compression with SKBitmap.Encode
1 participant